Skip to content

Conversation

@fayi-da
Copy link
Contributor

@fayi-da fayi-da commented Jun 10, 2025

Pull Request Checklist

Fixes https://github.com/DACH-NY/cn-test-failures/issues/4491

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@fayi-da fayi-da requested a review from martinflorian-da June 10, 2025 11:56
…est [static]

Signed-off-by: fayi-da <fayimora.femibalogun@digitalasset.com>
@fayi-da fayi-da force-pushed the fayi/update-test-ignore branch from 31394fc to f3cb3f8 Compare June 10, 2025 11:58
Copy link
Contributor

@martinflorian-da martinflorian-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! IMO we should still reference issues in PRs, even if they are on a non-public repo. Give at least a subset of the readers some context...

@fayi-da
Copy link
Contributor Author

fayi-da commented Jun 10, 2025

Thanks! IMO we should still reference issues in PRs, even if they are on a non-public repo. Give at least a subset of the readers some context...

I just asked the team this question, thanks!

@fayi-da fayi-da enabled auto-merge (squash) June 10, 2025 12:03
@fayi-da fayi-da merged commit bfa7481 into main Jun 10, 2025
41 checks passed
@fayi-da fayi-da deleted the fayi/update-test-ignore branch June 10, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants